Skip to content

fix connect app issue 2741 - [Team Management 2.0] Handle the case when email entered to be invited is already topcoder user #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

maxceem
Copy link
Contributor

@maxceem maxceem commented Jan 14, 2019

Fix for Connect App issue appirio-tech/connect-app#2741 - [Team Management 2.0] Handle the case when email entered to be invited is already topcoder user

…en email entered to be invited is already topcoder user
Copy link
Contributor

@RishiRajSahu RishiRajSahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxceem please address minor comments, check lint also, in case missed.

@maxceem
Copy link
Contributor Author

maxceem commented Jan 15, 2019

@RishiRajSahu added the check for email in unit tests. Lint is fine.

Copy link
Contributor

@RishiRajSahu RishiRajSahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RishiRajSahu RishiRajSahu merged commit cf04b21 into topcoder-platform:dev Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants